Fix for stored procedure empty cell bug #2887
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilemos
requested review from
Alekhya-Polavarapu,
Aniruddh25,
RubenCerna2079,
aaronburtle,
akashkumar58,
anushakolan,
neeraj-sharma2592,
rusamant,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where attempting to read empty string values from NVARCHAR or VARCHAR columns in stored procedures was causing internal server errors. The issue occurred when the GetChars method was called with a zero-length buffer.
- Adds early return for empty cells to prevent GetChars method calls with zero-length buffers
- Prevents internal server errors when reading empty string values from database columns
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gilemos
changed the title
vadeveka
reviewed
Sep 25, 2025
gilemos
changed the title
added 2 commits
September 26, 2025 10:01
… dev/gribeiro/emptyCellBug
Aniruddh25
reviewed
Sep 29, 2025
Aniruddh25
reviewed
Sep 29, 2025
Aniruddh25
requested changes
Sep 29, 2025
Co-authored-by: RubenCerna2079 <[email protected]>
…data-api-builder into dev/gribeiro/emptyCellBug
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
vadeveka
reviewed
Oct 9, 2025
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
We have recently noticed that, if we have a column of type NVARCHAR or VARCHAR and we try to run a stored procedure that reads a row in which that column has an empty string value, we had an internal server error.
This error happens when we try to run the method GetChars passing in a buffer with length 0
This PR aims to fix this problem
What is this change?
We have added a small change to the method that was throwing the exception.
If we find that resultFieldSize is 0 - which means that the data in the cell we are reading has a length of 0 - we will not call the method GetChars to read the data, but assume the data is empty and return the size of the data read in bytes as 0.
As you can see in the example bellow, that fixes the issue.
How was this tested?
Sample Request(s)
We have a table with a column of type NVARCHAR called "Description". In one of the rows, Description is an empty string
Before the changes:
If we try to run a stored procedure that reads that empty cell, we get an error
After changes
Stored procedure runs as expected