fix msha (#844): Regex for custom authentication providers #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
various documented providers currently do not work with the local authorization emulator (e.g. auth0, aadb2c), because numbers are not captured in the regex Fixes Azure#844
various documented providers currently do not work with the local authorization emulator (e.g. auth0, aadb2c), because numbers are not captured in the regex Fixes Azure#844
…jonnekleijer/static-web-apps-cli into fix/844-identity-provider-regex
github-actions
bot
added
the
scope: auth
Timothyw0
approved these changes
Nov 27, 2024
Timothyw0
pushed a commit
to Timothyw0/static-web-apps-cli
that referenced
this pull request
Dec 15, 2024
Timothyw0
pushed a commit
to Timothyw0/static-web-apps-cli
that referenced
this pull request
Dec 27, 2024
…ity-provider-regex" This reverts commit ec38949.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844: The regex ignores numbers in custom auth providers. Although various documented providers have numbers in their description (e.g. auth0, aadb2c). As a consequence they will not work with the local authorization emulator.