Skip to content

adding CacheLocationChoices so clients don't need to worry about type widening #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2019
Merged

adding CacheLocationChoices so clients don't need to worry about type widening #851

merged 2 commits into from
Jul 23, 2019

Conversation

jodonnell
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Jul 20, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@jodonnell
Copy link
Contributor Author

running npm run endToEnd was broken, npm run test failed one time and passed the next, so seems like there might be a flaky test?

i didn't want to change CacheLocation since probably a lot of users are relying on that so I just added a new enum that can be used instead.

@jodonnell jodonnell mentioned this pull request Jul 20, 2019
Closed
5 tasks
jasonnutter
jasonnutter approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks for the contribution!

sameerag
sameerag approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks much for this improvement.

@sameerag
Copy link
Member

Merging as we got the team's approval.

@jodonnell jodonnell mentioned this pull request Jul 22, 2019
Open
@pkanher617 pkanher617 merged commit 9e0dfe8 into AzureAD:dev Jul 23, 2019
pkanher617 pushed a commit that referenced this pull request Jul 23, 2019
Revert "Merge pull request #851 from jodonnell/dev"
9c043ea 
This reverts commit 9e0dfe8, reversing
changes made to 1b55af5.
@pkanher617
Copy link
Contributor

This ended up breaking surface configuration for cacheLocation, we will revert this PR and revisit the change in a future release.

pkanher617 pushed a commit that referenced this pull request Jul 23, 2019
Merge pull request #862 from AzureAD/revert-cache-location
cdbb29b 
Revert "Merge pull request #851 from jodonnell/dev"
@pkanher617
Copy link
Contributor

@jodonnell This was failing in typescript because it did not allow users to set string values for localstorage and sessionstorage and the enums weren't exported. Could you please test this in typescript and javascript to ensure the behavior is working correctly? You can open another PR, unfortunately I can't reopen this one.

@jodonnell
Copy link
Contributor Author

I will try to get this done in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@sameerag sameerag sameerag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jodonnell @msftclas @sameerag @pkanher617 @jasonnutter