[iOS SDK] Update Email OTP MFA to match EC implementation #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrescu84
requested review from
fidelianawar and
nazang
and removed request for
a team
nilo-ms
reviewed
Aug 26, 2025
| 289D138D2DF336390008CB1A /* MSALNativeAuthGenericError.swift in Sources */ = {isa = PBXBuildFile; fileRef = 289D13852DF336330008CB1A /* MSALNativeAuthGenericError.swift */; }; | ||
| 289D138E2DF336390008CB1A /* MSALNativeAuthGenericError.swift in Sources */ = {isa = PBXBuildFile; fileRef = 289D13852DF336330008CB1A /* MSALNativeAuthGenericError.swift */; }; | ||
| 289E15592948E601006104D9 /* MSALNativeAuthCacheInterface.swift in Sources */ = {isa = PBXBuildFile; fileRef = 289E15582948E601006104D9 /* MSALNativeAuthCacheInterface.swift */; }; | ||
| 289E156D2948EB8A006104D9 /* MSALNativeAuthCacheAccessor.swift in Sources */ = {isa = PBXBuildFile; fileRef = 289E156C2948EB8A006104D9 /* MSALNativeAuthCacheAccessor.swift */; }; |
There was a problem hiding this comment.
@spetrescu84 can you please update the changelog file too?
nilo-ms
reviewed
Aug 26, 2025
| telemetryUpdate: { [weak self] result in | ||
| self?.stopTelemetryEvent(event, context: context, delegateDispatcherResult: result) | ||
| }) | ||
| case .introspectRequired: |
There was a problem hiding this comment.
I think this type of result can't be returned by the API, so we can get rid of it
There was a problem hiding this comment.
I wasn't sure on this one, removed
nilo-ms
reviewed
Aug 26, 2025
MSAL/src/native_auth/controllers/sign_in/MSALNativeAuthSignInController.swift
Show resolved
Hide resolved
nilo-ms
approved these changes
Aug 26, 2025
antrix1989
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the SDK to match the latest flow from EC.
In this new flow, the developer must always supply an existing Method Id to the
/oauth2/v2.0/challengeendpoint which means once the.strongAuthRequirederror is received from any endpoint, the/oauth2/v2.0/introspectendpoint needs to be called to retrieve the methods which are automatically returned to be used by the developer.Furthermore whenever calling the
/tokenendpoint is called with an MFA Email OTP code, the grant type should bemfa_oobType of change
Risk
Additional information