Add global Request Adapter #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that ∙ - backend __init__ now holds the global request adapter and backend which get set on app initialisation ∙ request adapter and server can now be call from everywhere after the app initialised ∙ - added normal top level imports because the modules get matching loaded - but bad Import Error message when quart or equivilent are not installed ∙ - added _ as prefix to backends to avoid importing errors with their underlying ∙ - Can now move to remove unnecessary passing of the server object ∙
|
This is not finished, but shows all the main changes, let me know what you think! |
∙ replaced request.get_path with request.path ∙
…async removed remaining set request process from flask
…e flow. Made endpoints for downloading the reqs
|
Merging this for the restructure, I branched the old into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
∙ backends init now holds the global request adapter and backend which get set on app initialisation
∙ request adapter and server can now be call from everywhere after the app initialised
∙ added normal top level imports because the modules get matching loaded - but bad Import Error message when quart or equivilent are not installed
∙ added _ as prefix to backends to avoid importing errors with their underlying
∙ Can now move to remove unnecessary passing of the server object