Skip to content

NME: Support core SFE mode #16516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

alexchuber
Copy link
Contributor

This PR adds everything needed to support the “happy path” for creating SFE-compatible shaders in the Node Material Editor. In other words, all the core pieces are in place to build a default SFE NodeMaterial, as long as everything is set up correctly.

That said, there aren’t any UI guardrails yet — it’s still possible to break things or go off track. Guardrails and validation will come in future PRs.

  • Add ScreenUVBlock, which corresponds to the UV varying passed by postprocess.vertex, which is used by Smart Filters
  • Reuse NodeMaterialModes.PostProcess logic for creating the effect in the preview canvas. This avoid adding any more SFE-specific logic to NodeMaterial proper.
  • Add Export to SFE button

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

@deltakosh deltakosh merged commit c011ecd into BabylonJS:master Apr 22, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants