-
-
Notifications
You must be signed in to change notification settings - Fork 747
Updated GeolocatorPlatform #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
===========================================
+ Coverage 93.33% 100.00% +6.66%
===========================================
Files 1 17 +16
Lines 30 241 +211
===========================================
+ Hits 28 241 +213
+ Misses 2 0 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florissmit1, code looks good but the version should be updated as a breaking change. This should also be reflected in the changelog description (see suggestions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
Currently the
_token
object in theGeolocatorPlatform
is a const variable, which should be a final variable. Can cause version locking. Also replaced theverifyToken
method with theverify
method as mentioned in the issues in theLinks to relevant issues/docs
section.🆕 What is the new behavior (if this is a feature change)?
Solved the issue mentioned above
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
Does not apply
📝 Links to relevant issues/docs
flutter/flutter#96178
#937
flutter/plugins#4640
🤔 Checklist before submitting
master
.