Skip to content

Conversation

florissmit1
Copy link
Contributor

@florissmit1 florissmit1 commented Jan 12, 2022

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

Currently the _token object in the GeolocatorPlatform is a const variable, which should be a final variable. Can cause version locking. Also replaced the verifyToken method with the verify method as mentioned in the issues in the Links to relevant issues/docs section.

🆕 What is the new behavior (if this is a feature change)?

Solved the issue mentioned above

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Does not apply

📝 Links to relevant issues/docs

flutter/flutter#96178
#937
flutter/plugins#4640

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #942 (ca682e3) into master (6a8abab) will increase coverage by 6.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #942      +/-   ##
===========================================
+ Coverage   93.33%   100.00%   +6.66%     
===========================================
  Files           1        17      +16     
  Lines          30       241     +211     
===========================================
+ Hits           28       241     +213     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
...terface/lib/src/geolocator_platform_interface.dart 100.00% <100.00%> (ø)
geolocator/lib/geolocator.dart
...erface/lib/src/enums/location_accuracy_status.dart 100.00% <0.00%> (ø)
...ace/lib/src/errors/activity_missing_exception.dart 100.00% <0.00%> (ø)
...form_interface/lib/src/enums/location_service.dart 100.00% <0.00%> (ø)
...rc/errors/location_service_disabled_exception.dart 100.00% <0.00%> (ø)
...e/lib/src/errors/invalid_permission_exception.dart 100.00% <0.00%> (ø)
...terface/lib/src/extensions/integer_extensions.dart 100.00% <0.00%> (ø)
...e/lib/src/errors/already_subscribed_exception.dart 100.00% <0.00%> (ø)
...rors/permission_request_in_progress_exception.dart 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4987dd...ca682e3. Read the comment docs.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florissmit1, code looks good but the version should be updated as a breaking change. This should also be reflected in the changelog description (see suggestions).

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit 81c3389 into master Jan 12, 2022
@mvanbeusekom mvanbeusekom deleted the platform_interface_token_fix branch January 12, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use static final instead of static const for token used with plugin_platform_interface

2 participants