-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Adding PromptLayer support of tags #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested 1 change, can you send a screenshot of this logging working on Promptlayer
Thanks for the feedback @ishaan-jaff. I just realized a few issues in the test and PromptLayer integrations:
|
Hello @ishaan-jaff, do you see any other blockers ? Looking forward to get this merged ! :) |
Hi @samyxdev will review this today |
Hi everyone,
I noticed that LiteLLM doesn't support the
pl_tags
argument of the PromptLayer Python API, onlymetadata
is supported for now. In this PR, I propose to add the support of such tags by adding through themetadata
argument.Here is a working example with tags and metadata:
I also added a test to ensure the support of tags.
Note:
I thought about adding the
pl_tags
argument by itself (i.e. not inmetadata
) but it seems that LiteLLM is adding every extra argument as anextra_body
argument for OpenAI and Azure, which then leads to errors as the latter providers don't recognize this extrapl_tags
argument: https://github.com/BerriAI/litellm/blob/main/litellm/utils.py#L4072