Skip to content

ci: remove actions using Rust nightly #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024
Merged

ci: remove actions using Rust nightly #91

merged 1 commit into from
Oct 10, 2024

Conversation

benma
Copy link
Contributor

@benma benma commented Oct 10, 2024

Nightly quite often breaks CI by introducing new clippy linters etc, which disrupts one's work when one wants to land a PR whose CI suddenly fails for unrelated reasons.

Sometimes, the new linters are also broken and result in false positives. The one that prompted this commit is a false positive about needless_return like this:
rust-lang/rust-clippy#13526

error: unneeded `return` statement
   --> tests/simulator_tests.rs:212:51
    |
212 |       for simulator_filename in simulator_filenames {
    |  ___________________________________________________^
213 | |         println!("Simulator tests using {}", simulator_filename);
214 | |         let _server = Server::launch(&simulator_filename);
...   |
244 | |         test_btc(&paired_bitbox).await
245 | |     }

(there is no return statement)

Nightly quite often breaks CI by introducing new clippy linters etc,
which disrupts one's work when one wants to land a PR whose CI
suddenly fails for unrelated reasons.

Sometimes, the new linters are also broken and result in false
positives. The one that prompted this commit is a false positive about
needless_return like this:
rust-lang/rust-clippy#13526

```
error: unneeded `return` statement
   --> tests/simulator_tests.rs:212:51
    |
212 |       for simulator_filename in simulator_filenames {
    |  ___________________________________________________^
213 | |         println!("Simulator tests using {}", simulator_filename);
214 | |         let _server = Server::launch(&simulator_filename);
...   |
244 | |         test_btc(&paired_bitbox).await
245 | |     }
```

(there is no return statement)
@benma benma merged commit dc55eac into master Oct 10, 2024
6 checks passed
@benma benma deleted the remove-nightly branch October 10, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant