Unlock reduce sc events #1622
Draft
Unlock reduce sc events #1622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default implementation is in terms of other HAL/UI functions. For unit tests (e.g. in show_mnemonic.rs or bip85.rs), it is useful to be able to skip over the implementation details, so the tests don't have to mock selecting the right words in the quiz.
This also allows us to keep track of the number of secure chip operations in all the scenarios.
The sanity check to see if the seed has changed does not need a securechip operation, it can use the retained seed hash instead, same as `unlock_bip39()`. This reduces the number of securechip operations needed to do a password check, which reduces the risk of running into the Optiga throttling security mechanism.
benma
force-pushed
the
unlock-reduce-sc-events
branch
from
c2562be to
4fcc8cd
Compare
Every call to `keystore::unlock` is followed by `copy_seed()`. The latter uses a secure chip operation. We can remove that by returning the seed from unlock and re-using it. This reduces the number of securechip operations by 1 when: - when unlocking the device - showing mnemonic on initialized device - creating backu on initialized device This is to reduce the risk of running into Optiga's throttling security mechanism.
benma
force-pushed
the
unlock-reduce-sc-events
branch
from
4fcc8cd to
7cd4971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1619