Skip to content

Conversation

nvjsr
Copy link
Contributor

@nvjsr nvjsr commented Sep 4, 2025

TICKET: COIN-5193

This pull request adds support for EVM keyring wallet and address creation by introducing new parameters and validation logic, as well as utility functions and comprehensive unit tests. The changes allow wallets and addresses on EVM chains to reference keys and addresses from other wallets, improving flexibility and key management. Validation ensures these features are only available for EVM-compatible coins and that provided references are correct.

EVM Keyring Wallet and Address Support

  • Added evmKeyRingReferenceWalletId and evmKeyRingReferenceAddress parameters to wallet and address creation interfaces, enabling wallets and addresses to reference existing EVM wallets and addresses.
  • Implemented validation logic to ensure these parameters are only used with EVM chains and are of the correct type and format.

Utility Functions

  • Added validateEvmKeyRingWalletParams and createEvmKeyRingWallet utility functions to handle validation and creation of EVM keyring wallets, bypassing standard multisig validation when a reference wallet is provided.

Wallet and Address Creation Logic

  • Updated the wallet and address creation logic to support the new EVM keyring parameters, including skipping multisig validation and handling reference wallet inheritance for EVM chains.

Unit Tests

  • Added thorough unit tests for EVM keyring wallet and address creation, covering valid usage, error cases, and non-EVM chain restrictions.

@nvjsr nvjsr force-pushed the COIN-5193-EvmKeyring branch from 25f2d2c to 659b421 Compare September 4, 2025 13:29
@nvjsr nvjsr marked this pull request as ready for review September 4, 2025 13:29
@nvjsr nvjsr requested review from a team as code owners September 4, 2025 13:29
@nvjsr nvjsr force-pushed the COIN-5193-EvmKeyring branch from 659b421 to 50a2f14 Compare September 4, 2025 14:05
Copy link
Contributor

@yogeshwar-bitgo yogeshwar-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kisslove-dewangan kisslove-dewangan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@shivam-bitgo shivam-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nvjsr nvjsr merged commit a514410 into master Sep 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants