Skip to content

fix: failing vechain tests #6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

fix: failing vechain tests #6894

merged 1 commit into from
Sep 5, 2025

Conversation

Gautam2305
Copy link
Contributor

@Gautam2305 Gautam2305 commented Sep 5, 2025 •
edited
Loading

Ticket: SC-2858

  • incorrect EXIT_DELEGATION_METHOD_ID was being passed earlier
  • these tests were failing locally but passed by the github checks

@Gautam2305 Gautam2305 marked this pull request as ready for review September 5, 2025 09:32
@Gautam2305 Gautam2305 requested a review from a team as a code owner September 5, 2025 09:32
abhijit0943
abhijit0943 approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@abhijit0943 abhijit0943 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Doddanna17
Copy link
Contributor

@claude

abhishekagrawal080
abhishekagrawal080 approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@abhishekagrawal080 abhishekagrawal080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gautam2305 Gautam2305 merged commit 30c4502 into master Sep 5, 2025
11 checks passed
@Gautam2305 Gautam2305 mentioned this pull request Sep 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doddanna17 Doddanna17 Doddanna17 approved these changes

@abhijit0943 abhijit0943 abhijit0943 approved these changes

@abhishekagrawal080 abhishekagrawal080 abhishekagrawal080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gautam2305 @Doddanna17 @abhijit0943 @abhishekagrawal080