refactor(apt): changes to validation and test cases #6921
Merged
+118
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: COIN-5352
This pull request refactors and centralizes validation logic for Aptos custom transaction module and function names, ensuring stricter compliance with expected formats (hex addresses only for module names). It also updates usage throughout the codebase to leverage the new validation utilities, improves test coverage for valid and invalid cases, and adds new tests for custom token mint and burn transactions.
Validation logic refactor and enforcement:
utils/validation.ts
for module and function names, providing both throwing (validateModuleName
,validateFunctionName
) and non-throwing (isValidModuleName
,isValidFunctionName
) variants. These utilities enforce module names to use only hex addresses and valid function identifiers.CustomTransaction
and replaced their usage with calls to the centralized validation utilities.Transaction builder validation updates:
CustomTransactionBuilder
to use the new validation utilities for checking module and function name formats, removing previous regex and address checks.Testing improvements: