feat(sdk-coin-tao): add moveStakeBuilder #6925

raksha-r7 · 2025-09-09T14:33:18Z

raksha-r7 · 2025-09-09T15:09:47Z

modules/sdk-coin-tao/test/unit/transactionBuilder/moveStakeBuilder.ts

+import { assert as SinonAssert, spy } from 'sinon';
+import { MoveStakeBuilder } from '../../../src/lib/moveStakeBuilder';
+import utils from '../../../src/lib/utils';
+import { accounts, mockTssSignature, rawTx, genesisHash, chainName } from '../../resources';


To fix the problem, we should remove the unused import rawTx from the import statement on line 6 in modules/sdk-coin-tao/test/unit/transactionBuilder/moveStakeBuilder.ts.

Specifically, edit the import statement to exclude rawTx, retaining the other imports if they are used.

Only the import line needs modification; no further code edits are required unless other unused imports exist (but CodeQL flagged only rawTx).

raksha-r7 · 2025-09-09T15:18:58Z

@claude review

modules/sdk-coin-tao/src/lib/moveStakeBuilder.ts

Doddanna17

Please check the comments

Ticket: SC-3017

Copilot

Pull Request Overview

This PR adds support for moving stake between hotkeys in the TAO network by implementing a new moveStakeBuilder transaction builder.

Adds MoveStakeBuilder and MoveStakeTransaction classes to handle move stake operations
Extends transaction factory to support move stake transaction type
Adds comprehensive test coverage for the move stake functionality

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
modules/sdk-coin-tao/test/unit/transactionBuilder/moveStakeBuilder.ts	Comprehensive test suite for MoveStakeBuilder functionality
modules/sdk-coin-tao/src/lib/transactionBuilderFactory.ts	Adds getMoveStakeBuilder method and factory routing
modules/sdk-coin-tao/src/lib/moveStakeTransaction.ts	Transaction class for move stake operations
modules/sdk-coin-tao/src/lib/moveStakeBuilder.ts	Builder class for constructing move stake transactions
modules/sdk-coin-tao/src/lib/index.ts	Exports new move stake classes
modules/sdk-coin-tao/src/lib/iface.ts	Adds MoveStakeTxData interface
modules/sdk-coin-tao/src/lib/constants.ts	Defines TAO network constants
modules/abstract-substrate/src/lib/utils.ts	Adds isMoveStake utility method
modules/abstract-substrate/src/lib/txnSchema.ts	Adds validation schema for move stake transactions
modules/abstract-substrate/src/lib/iface.ts	Adds move stake interfaces and method names

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-10T14:48:08Z

modules/sdk-coin-tao/test/unit/transactionBuilder/moveStakeBuilder.ts

+      explanation.outputs[0].should.deepEqual({
+        address: '5Ffp1wJCPu4hzVDTo7XaMLqZSvSadyUQmxWPDw74CBjECSoq',
+        amount: '9007199254740995',
+        tokenName: 'ttao:apex',
+      });


The hardcoded tokenName 'ttao:apex' appears to be a magic value. Consider using a constant or deriving it from the test data to make the test more maintainable and less brittle.

Copilot · 2025-09-10T14:48:08Z

modules/sdk-coin-tao/test/unit/transactionBuilder/moveStakeBuilder.ts

+      mockBuilder['_method'] = {
+        name: 'transferKeepAlive',
+        args: { dest: { id: 'test' }, value: '1000' },
+        pallet: 'balances',
+      };


Direct access to private fields using bracket notation makes the test brittle and violates encapsulation. Consider adding a test-only setter method or refactoring the builder to support this test scenario more cleanly.

Copilot · 2025-09-10T14:48:09Z

modules/sdk-coin-tao/src/lib/moveStakeBuilder.ts

+  private validateNetuid(netuid: string): void {
+    const netuidNum = Number(netuid);
+    if (isNaN(netuidNum) || !Number.isInteger(netuidNum) || netuidNum < 0 || netuidNum > TAO_CONSTANTS.MAX_NETUID) {
+      throw new InvalidTransactionError(
+        `Invalid netuid: ${netuid}. Netuid must be between 0 and ${TAO_CONSTANTS.MAX_NETUID}.`
+      );
+    }
+  }


The validation allows decimal numbers that convert to integers (e.g., '5.0' becomes 5). Use parseInt() with radix 10 and check if the result equals the original input, or use a regex to ensure the input contains only digits.

github-advanced-security bot found potential problems Sep 9, 2025

View reviewed changes

raksha-r7 force-pushed the SC-3017 branch from 6efec99 to c100d46 Compare September 9, 2025 14:52

raksha-r7 marked this pull request as ready for review September 9, 2025 15:21

raksha-r7 requested a review from a team as a code owner September 9, 2025 15:21

Doddanna17 reviewed Sep 10, 2025

View reviewed changes

modules/sdk-coin-tao/src/lib/moveStakeBuilder.ts Outdated Show resolved Hide resolved

Doddanna17 requested a review from Copilot September 10, 2025 03:40

This comment was marked as outdated.

Sign in to view

Doddanna17 requested changes Sep 10, 2025

View reviewed changes

raksha-r7 force-pushed the SC-3017 branch 3 times, most recently from d196a1b to 68ad0d3 Compare September 10, 2025 10:17

raksha-r7 requested a review from Doddanna17 September 10, 2025 10:40

Doddanna17 requested a review from Copilot September 10, 2025 11:54

This comment was marked as outdated.

Sign in to view

feat(sdk-coin-tao): add moveStakeBuilder

259d850

Ticket: SC-3017

raksha-r7 force-pushed the SC-3017 branch from 68ad0d3 to 259d850 Compare September 10, 2025 11:59

raksha-r7 requested a review from Copilot September 10, 2025 14:46

Copilot AI reviewed Sep 10, 2025

View reviewed changes

@@ -3,7 +3,7 @@
             import { assert as SinonAssert, spy } from 'sinon';
             import { MoveStakeBuilder } from '../../../src/lib/moveStakeBuilder';
             import utils from '../../../src/lib/utils';
-            import { accounts, mockTssSignature, rawTx, genesisHash, chainName } from '../../resources';
+            import { accounts, mockTssSignature, genesisHash, chainName } from '../../resources';
             import { buildTestConfig } from './base';
             import { testnetMaterial } from '../../../src/resources';
             import { InvalidTransactionError } from '@bitgo/sdk-core';

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(sdk-coin-tao): add moveStakeBuilder #6925

feat(sdk-coin-tao): add moveStakeBuilder #6925

raksha-r7 commented Sep 9, 2025

Uh oh!

Check notice

Copilot Autofix

raksha-r7 Sep 9, 2025

Uh oh!

raksha-r7 commented Sep 9, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Doddanna17 left a comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 10, 2025

Uh oh!

Copilot AI Sep 10, 2025

Uh oh!

Copilot AI Sep 10, 2025

Uh oh!

Uh oh!

feat(sdk-coin-tao): add moveStakeBuilder #6925

Are you sure you want to change the base?

feat(sdk-coin-tao): add moveStakeBuilder #6925

Conversation

raksha-r7 commented Sep 9, 2025

Uh oh!

Check notice

Copilot Autofix

raksha-r7 Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

raksha-r7 commented Sep 9, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Doddanna17 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!