Skip to content

added accessibility testing to GitHub actions #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TimOsahenru
Copy link
Contributor

Issue Link 🔗:

Issue: #577

Type of Change

  • Bug fix 🐞
  • New feature/page
  • Documentation update
  • Other

Description 📋

  • What:
    This PR introduces accessibility testing to our test suite to ensure our application meets accessibility standards. The key changes include:

    • Integrated accessibility tests into the test suite.
    • Created a GitHub Actions workflow to automatically run accessibility tests on each push/PR.
  • Why:
    With this addition, we can proactively catch and fix accessibility-related issues, improving the overall user experience.

  • How:

    • Ran tests locally and confirmed most accessibility checks passed as most tests are failing (a follow-up PR will address the failing accessibility tests).
    • Verified that the GitHub Actions workflow successfully executes the tests.

Checklist ✅

  • Followed the Code of Conduct and Contribution Guide
  • Ran pre-commit run --all
  • All tests pass locally
  • Added tests (if applicable)
  • Documentation updated (if applicable)

Additional Notes & Screenshots

Add any additional notes or comments that might be helpful for the reviewers.

Sorry, something went wrong.

- Integrated axe-core-python into existing test cases to check for accessibility violations
@TimOsahenru TimOsahenru requested a review from kjaymiller March 21, 2025 18:03
Copy link
Contributor

@kjaymiller kjaymiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good!

I only think we need to update the requirements page as it has all the things (with versions pinned) that is not necessary

@TimOsahenru
Copy link
Contributor Author

Hey Jay, I would love to merge this only when I've been able to fix the failing test locally. Just to be cautious 😂

@kjaymiller
Copy link
Contributor

That makes sense for me. I will leave open.

@TimOsahenru TimOsahenru merged commit e68d620 into BlackPythonDevs:gh-pages Apr 3, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants