Skip to content

Fix accessibility failing test #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TimOsahenru
Copy link
Contributor

Issue Link 🔗:

Issue: #654

Type of Change

  • Bug fix 🐞
  • New feature/page
  • Documentation update
  • Other

Description 📋

  • Tweaked all the tests to run only WCAG 2.1 level A and AA rules as to running all the validity checks that axe-core support we can later remove the flags for stricter best practices results = axe.run(page, options={"runOnly": ["wcag2a", "wcag2aa"]}) instead of results = axe.run(page)

  • Included a script for including the titles of auto-generated iframes

    script.onload = function () {
                  const observer = new MutationObserver(function (mutations) {
                    const iframe = document.querySelector(".commitchange-iframe-embedded");
                    if (iframe && !iframe.hasAttribute("title")) {
                      iframe.setAttribute("title", "Donation form for Black Python Devs");
                      observer.disconnect(); // Stop observing once we've set the title
                    }
                  });
    
                  observer.observe(document.body, { childList: true, subtree: true });
                };
  • Since we currently don't have support for multiple languages. I changed the LANG_ROUTES from

      LANG_ROUTES = (
      "/",
      "/about/",
      "/events/",
      "/community/",
      "/support/",
      "/blog/",
      )
- 
## Checklist ✅

- [x] Followed the [Code of Conduct](https://github.com/BlackPythonDevs/blackpythondevs.github.io?tab=coc-ov-file) and [Contribution Guide](https://github.com/BlackPythonDevs/blackpythondevs.github.io/blob/469afd71943738b7209bfe56d5a4e35394fbaafc/CONTRIBUTING.md)
- [x] Ran `pre-commit run --all`
- [x] All tests pass locally
- [ ] Added tests (if applicable)
- [ ] Documentation updated (if applicable)

@TimOsahenru TimOsahenru requested a review from kjaymiller April 3, 2025 01:43
@TimOsahenru TimOsahenru merged commit e5100c9 into BlackPythonDevs:gh-pages Apr 4, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants