Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ jobs:

strategy:
matrix:
ruby-version: [ "3.0.3", "3.1.1" ]
ruby-version: [ "3.0.7", "3.1.6", "3.2.6", "3.3.7", "3.4.1" ]

steps:
- uses: actions/checkout@v2

Expand Down
14 changes: 12 additions & 2 deletions lib/messagebird/request_validator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ def decode_signature(signature)

def validate_url(url, url_hash)
expected_url_hash = Digest::SHA256.hexdigest url
unless JWT::SecurityUtils.secure_compare(expected_url_hash, url_hash)
unless secure_compare(expected_url_hash, url_hash)
raise ValidationError, 'invalid jwt: claim url_hash is invalid'
end
end

def validate_payload(body, payload_hash)
if !body.to_s.empty? && !payload_hash.to_s.empty?
unless JWT::SecurityUtils.secure_compare(Digest::SHA256.hexdigest(body), payload_hash)
unless secure_compare(Digest::SHA256.hexdigest(body), payload_hash)
raise ValidationError, 'invalid jwt: claim payload_hash is invalid'
end
elsif !body.to_s.empty?
Expand All @@ -87,5 +87,15 @@ def validate_payload(body, payload_hash)
raise ValidationError, 'invalid jwt: claim payload_hash is set but actual payload is missing'
end
end

# Adaption of https://github.com/rails/rails/blob/cf6ff17e9a3c6c1139040b519a341f55f0be16cf/activesupport/lib/active_support/security_utils.rb#L33
# Copied here so as to avoid adding a dependency on ActiveSupport to this gem
#
# Note that unlike `fixed_length_secure_compare` in the above url we don't fall back to a custom implementation
# of fixed_length_secure_compare, since OpenSSL.fixed_length_secure_compare is present in OpenSSL 2.2
# https://github.com/ruby/openssl/blob/master/History.md#version-220 which is included in Ruby 3.0 and above
def secure_compare(first, second)
first.bytesize == second.bytesize && OpenSSL.fixed_length_secure_compare(first, second)
end
end
end
5 changes: 4 additions & 1 deletion messagebird-rest.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ Gem::Specification.new do |s|
s.files = Dir.glob('lib/**/*') + %w(LICENSE README.md)
s.require_path = 'lib'

s.add_dependency "jwt", "~> 2.3"
# This code works with at least version 3.0.0.beta1 of jwt,
# so we are supporting up to version 4 to help reduce
# the necessity for future version bumps
s.add_dependency "jwt", "< 4"

s.add_development_dependency "rspec", "~> 3.11.0"
s.add_development_dependency "rubocop", "~> 1.26.1"
Expand Down
Loading