Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Set compilation flags for different build types with Clang #734

Merged
merged 6 commits into from
Jan 6, 2022
Merged

Set compilation flags for different build types with Clang #734

merged 6 commits into from
Jan 6, 2022

Conversation

pramodk
Copy link
Collaborator

@pramodk pramodk commented Jan 4, 2022 •
edited
Loading

Description

  • Clang compiler flags were not added
  • Because of this, no flags were set for RelWithDebInfo or
    any other build types
  • Update tqperf test script for Jenkins CI
    • update tqperf GitHub URL
    • mod files are now into two directories, need to use mod + modx

How to test this?

module load unstable gcc llvm cmake python 
cmake ..

-- Configured CoreNEURON 1.0
--
-- You can now build CoreNEURON using:
--   cmake --build . --parallel 8 [--target TARGET]
-- You might want to adjust the number of parallel build jobs for your system.
-- Some non-default targets you might want to build:
-- --------------------+--------------------------------------------------------
--  Target             |   Description
-- --------------------+--------------------------------------------------------
-- install             | Will install CoreNEURON to: /usr/local
-- docs                | Build full docs. Calls targets: doxygen, sphinx
-- --------------------+--------------------------------------------------------
--  Build option       | Status
-- --------------------+--------------------------------------------------------
-- CXX COMPILER        | /gpfs/bbp.cscs.ch/ssd/apps/bsd/2021-11/stage_externals/install_gcc-11.2.0-skylake/llvm-13.0.0-lvcrm6/bin/clang++
-- COMPILE FLAGS       |  -fopenmp=libomp   -g  -O2 -std=c++14

Previously -g -O2 were not added.

Test System

  • System: BB5
  • Compiler: LLVM
  • Backend: CPU

@pramodk
Set compilation flags for different build types with Clang
da3d1d3 
 - Clang compiler flags were not added
 - Because of this, no flags were set for RelWithDebInfo or
   any other build types
@pramodk pramodk requested review from alkino and olupton January 4, 2022 21:17
@pramodk pramodk mentioned this pull request Jan 4, 2022
Draft
2 tasks
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #30795 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #30810 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #30872 (:no_entry:) have been uploaded here!

Status and direct links:

@olupton
Copy link
Contributor

olupton commented Jan 5, 2022

The remaining Jenkins failure looks related to neuronsimulator/tqperf@9dbb4e6#diff-afb9814ace89cfe422329aa50414e7a8b75b0a7d88df9a2efd6c283af46d5d59.

@pramodk pramodk closed this Jan 5, 2022
@pramodk pramodk reopened this Jan 5, 2022
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #30898 (:no_entry:) have been uploaded here!

Status and direct links:

@olupton olupton merged commit ba85c4c into master Jan 6, 2022
@olupton olupton deleted the pramodk/clang-flags branch January 6, 2022 08:46
pramodk added a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
@pramodk
Set compilation flags for different build types with Clang (BlueBrain…
b05a8dd 
…/CoreNeuron#734)

* Set compilation flags for different build types with Clang:
 - Clang compiler flags were not added.
 - Because of this, no flags were set for RelWithDebInfo or
   any other build types.
* Update tqperf test:
 - Change repository URL.
 - Copy mod files into single directory.
 - Pass extra linker flags.

Co-authored-by: Olli Lupton <[email protected]>

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@ba85c4c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@alkino alkino alkino approved these changes

@olupton olupton olupton approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pramodk @bbpbuildbot @olupton @alkino