Skip to content

Fixes #168: Cast error messages to string #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

Fixes #168: Cast error messages to string #171

merged 1 commit into from
Nov 3, 2021

Conversation

JosXa
Copy link
Contributor

@JosXa JosXa commented Sep 21, 2021

No description provided.

ryallen-nokia
ryallen-nokia approved these changes Oct 15, 2021
View reviewed changes
Copy link

@ryallen-nokia ryallen-nokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I experienced this same issue starting the generated project

alexiamcdonald
alexiamcdonald approved these changes Oct 20, 2021
View reviewed changes
Copy link

@alexiamcdonald alexiamcdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm these changes allowed for frontend code to compile

@Proteusiq
Copy link

Could we use err as string instead of String(err)?

@cardoe cardoe mentioned this pull request Nov 2, 2021
Open
@Buuntu Buuntu merged commit b4a9d54 into Buuntu:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@alexiamcdonald alexiamcdonald alexiamcdonald approved these changes

@ryallen-nokia ryallen-nokia ryallen-nokia approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JosXa @Proteusiq @alexiamcdonald @ryallen-nokia @Buuntu