This repository was archived by the owner on Feb 9, 2023. It is now read-only.
Hidden State으로 전환될 때 Animation 추가 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…동 후 숨김처리할 수 있도록 변경
|
딜레이를 넣은 것 외에도 다른 코드가 보이는데, 어떤 작업들이 진행된 것인가요? |
|
Hidden State으로 상태가 바뀔때 기존에는 버튼이 사라지기만 했었는데, 정해진 위치로 이동하는 애니메이션을 추가했습니다. |
ybbarng
reviewed
Mar 20, 2019
| final PositionDock positionToHide = mHoverView.getPositionToHide(); | ||
| if (positionToHide == null) { | ||
| mHoverView.setVisibility(View.GONE); | ||
| onStateChanged.run(); |
There was a problem hiding this comment.
제가 코드를 잘 모르는데, onStateChanged가 Null일 가능성은 없을까요?
ybbarng
reviewed
Mar 20, 2019
| if (!hasControl() || !mHoverView.mIsAddedToWindow) { | ||
| return; | ||
| } | ||
| onStateChanged.run(); |
ybbarng
approved these changes
Mar 20, 2019
|
onStateChanged의 경우, Hidden state으로 전환될때마다 객체를 생성해서 넘겨주고 있어서 null일 경우가 없어보입니다! |
delete-merged-branch
bot
deleted the
feature/hidden_state_animation_support
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HiddenState로 state가 전환될 때, onStateChanged listener를 호출 한 후 바로 view의 visibility를 바꿀 경우 버튼이 깜빡거리는듯한 느낌을 주게됩니다. 그래서 handler를 사용해 약간의 딜레이를 넣었습니다.