This repository was archived by the owner on Feb 9, 2023. It is now read-only.
Collapsed state일 때 일정 시간이 지나면 반투명해지거나 아이콘이 사라질 수 있도록 설정할 수 있게 변경 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybbarng
reviewed
Apr 11, 2019
| if (!(state instanceof HoverViewStatePreviewed) && state instanceof HoverViewStateCollapsed) { | ||
| mHoverView.setAlpha(0.4f); | ||
| if (mHoverView.shouldKeepVisible()) { | ||
| mHoverView.setAlpha(0.4f); |
There was a problem hiding this comment.
0.4f를 클래스 앞쪽이나 어딘가에 상수로 빼두면 추후에 관리하기 용이할 것 같습니다.
기획적인 측면이어서 그냥 아이디어입니다만 바로 alpha 값을 변경하는 것보다는 서서히 변하는 게 더 자연스럽게 보일 수 있을 것 같기도 합니다.
There was a problem hiding this comment.
상수로 빼두는것은 좋을것 같네요! 수정해둘게요.
Alpha 값을 변경하는 부분은 이야기를 조금 해봐야할 것 같네요 ㅎㅎ
ybbarng
reviewed
Apr 11, 2019
| OnExitListener mOnExitListener; | ||
| private final Set<OnStateChangeListener> mOnStateChangeListeners = new CopyOnWriteArraySet<>(); | ||
| private final Set<OnInteractionListener> mOnInteractionListeners = new CopyOnWriteArraySet<>(); | ||
| private boolean mKeepVisible; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
일정 시간이 지났을 때 아이콘이 사라졌으면 좋겠다는 의견이 있어서 옵션으로 켰다 껐다 할 수 있도록 구현을 했습니다.