Skip to content
This repository was archived by the owner on Feb 9, 2023. It is now read-only.

Conversation

josh-yun
Copy link

No description provided.

@josh-yun josh-yun requested a review from SeoJungHong February 13, 2019 09:29
}

protected void restoreHoverViewAlphaValue() {
mHandler.removeCallbacksAndMessages(null);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 나중에 다른 delayed 된 runnable 이 추가될 수도 있으니 removeCallbacks(Runnable r) 를 사용하는 것이 어떨까요?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트중에 runnable이 안없어지는 것 같아 확실하게 해보려고 바꿔둔걸 그대로 뒀네요. 바꿀게요!

Copy link

@SeoJungHong SeoJungHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second, alpha 값을 퍼블리셔가 커스터마이징 가능하게 API 를 빼줘야 할지 생각해 봤는데 일단은 요청이 올때까지는 굳이 안만들어도 될 것 같습니다. Alpha 값만 나중에 디자인 팀한테 피드백을 받아보죠~ LGTM 입니다!

@josh-yun josh-yun merged commit d5f9f92 into master Feb 14, 2019
@josh-yun josh-yun deleted the feature/collapsed_state_transparency branch February 14, 2019 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants