Skip to content

remove briansmith/webpki, tidy up rustls-webpki harness, add ML-DSA support #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpu merged 13 commits into from
Jul 29, 2026
Merged

remove briansmith/webpki, tidy up rustls-webpki harness, add ML-DSA support #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
af376d7
harness: fix clippy findings in Rust harnesses
cpu Jul 29, 2026
d30b429
ci: lint Rust code with rustfmt and clippy
cpu Jul 29, 2026
685f48e
harness: remove briansmith/webpki harness
cpu Jul 29, 2026
67f8f0c
rust-rustls: import types instead of qualifying paths
cpu Jul 29, 2026
641a23b
rust-rustls: only verify peer name when one is expected
cpu Jul 29, 2026
1a1039c
rust-rustls: extract validation into run_validation
cpu Jul 29, 2026
258d27a
rust-rustls: parse PEM with pki-types
cpu Jul 29, 2026
2a339ad
rust-rustls: re-order validation setup to match upstream
cpu Jul 29, 2026
f41fa52
rust-rustls: defer Utc::now() with unwrap_or_else
cpu Jul 29, 2026
8cd8321
rust-rustls: chain revocation options builder calls
cpu Jul 29, 2026
59ab743
rust-rustls: verify with ALL_VERIFICATION_ALGS
cpu Jul 29, 2026
16f6189
rust-rustls: use the aws-lc-rs backend
cpu Jul 29, 2026
20b782a
rust-rustls: verify ML-DSA signatures (RFC 9881)
cpu Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,33 @@ jobs:
- name: lint
run: make lint

rustfmt:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false

- name: check formatting
run: cargo fmt --all -- --check

clippy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false

- name: clippy
run: cargo clippy --locked --workspace --all-targets -- --deny warnings

all-lints-pass:
if: always()

needs:
- lint
- rustfmt
- clippy

runs-on: ubuntu-latest

Expand Down
123 changes: 86 additions & 37 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[workspace]
resolver = "2"
members = ["harness-support/rust", "harness/rust-webpki", "harness/rust-rustls"]
members = ["harness-support/rust", "harness/rust-rustls"]
8 changes: 1 addition & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ testcases: $(NEEDS_VENV)
build-harnesses:
$(MAKE) -C harness/gocryptox509
$(MAKE) -C harness/openssl
cargo build --bin rust-webpki-harness
cargo build --bin rust-rustls-harness

.PHONY: test-go
Expand Down Expand Up @@ -109,11 +108,6 @@ test-aws-lc:
$(MAKE) -C harness/openssl aws-lc
$(MAKE) run ARGS="harness --output ./results/aws-lc.json -- docker run --rm -i x509-limbo-aws-lc"

.PHONY: test-rust-webpki
test-rust-webpki:
@cargo build --bin rust-webpki-harness
$(MAKE) run ARGS="harness ./target/debug/rust-webpki-harness --output ./results/rust-webpki.json"

.PHONY: test-rustls-webpki
test-rustls-webpki:
@cargo build --bin rust-rustls-harness
Expand All @@ -132,7 +126,7 @@ test-gnutls:
$(MAKE) run ARGS="harness --output ./results/gnutls.json -- ./$(VENV_BIN)/python ./harness/gnutls/test-gnutls"

.PHONY: test
test: test-go test-openssl test-libressl test-boringssl test-aws-lc test-rust-webpki test-rustls-webpki test-pyca-cryptography test-certvalidator test-gnutls
test: test-go test-openssl test-libressl test-boringssl test-aws-lc test-rustls-webpki test-pyca-cryptography test-certvalidator test-gnutls

.PHONY: site
site: $(NEEDS_VENV)
Expand Down
9 changes: 6 additions & 3 deletions harness/rust-rustls/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ edition = "2021"
[dependencies]
limbo-harness-support = { path = "../../harness-support/rust" }
chrono = "0.4.44"
pem = "3.0.6"
serde_json = "1.0.150"
rustls-webpki = { version = "0.103.13", features = ["std", "ring"] }
rustls-pki-types = "1.14.1"
rustls-webpki = { version = "0.103.13", features = [
"std",
"aws-lc-rs",
"aws-lc-rs-unstable",
] }
pki-types = { package = "rustls-pki-types", version = "1.14.1" }
Loading
Loading