Formatting of HTML notifications

[ageis]

There seems to be a bug in /lib/encrypt_mails.rb so all of our encrypted ticket update notifications are being sent in plaintext (the plugin uses PGP/MIME, which is good and should support HTML), even though Redmine's email notification settings are solidly set to use HTML and not plaintext.

The "filtered" notifications, however, are being formatted as HTML.

This is something to investigate and fix.

[timegrid]

Well - it was more like a bug in my philosophy of life. I thought, the equation pgp + html = buggy holds for all worlds and all times. Thanks for the update.

[timegrid]

@ageis I added the line to the develop branch. But, considering this further, there might be a problem, when users receive pgp/mime encrypted, clean html mails, but answer with pgp/inline encrypted, broken html. I can almost smell the bug reports. I don't know, if nowadays the email clients / plugins are clever enough to prevent the users from sending html pgp/inline. Maybe a new plugin setting "html in encrypted mails?" and a note in the readme would clarify the implications?

[ageis]

@timegrid Thunderbird + Enigmail, which I think is the most popular PGP e-mail implementation uses PGP/MIME by default. When you switch to inline PGP mode in that client, it automatically strips HTML tags and converts emails to plain text.

Before you can test this with possible other clients that only support inline, plain text PGP, and fully understand the implications, I agree a plugin setting makes sense.

[timegrid]

@ageis works for me

[ageis]

@timegrid Now that you've added the option, here's the behavior I'm seeing, which corresponds to what you predicted in an earlier comment.

With HTML notifications enabled, only PGP/MIME incoming replies are processed. Inline PGP replies are being disregarded for some reason.

With HTML notifications disabled, both PGP/MIME and inline PGP replies are processed correctly.

It seems counter-intuitive that the outgoing notification setting would affect the way incoming mails are received. Do you have any thoughts on how we can fix this for greater compatibility in the first instance? Could it have something to do with the 'Reply above this line' marker?

[ageis]

It would be ideal if incoming mail processing worked independent of what the outgoing format/setting is. When HTML notifications are enabled, the system can't process plaintext inline-PGP replies to those HTML notifications, and only PGP/MIME works. When I get a moment I'll look at the code and try to see if there might be a solution, otherwise I think we'll just have to advise users to use PGP/MIME only.