Skip to content

fix: remove unnecessary import statement #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

exKAZUu
Copy link
Contributor

@exKAZUu exKAZUu commented Mar 9, 2021

Close #121

import 'firebase/auth'; is unnecessary and should be written in user code. It causes #121 issue.
(The current rollup settings doesn't consider firebase/auth as an external library, so firebase/auth is bundled in react-firebase-hooks/auth.)

@chrisbianca chrisbianca merged commit 62e42f4 into CSFrequency:master Mar 9, 2021
@chrisbianca
Copy link
Contributor

@exKAZUu thanks for the catch and quick PR! I'm going to take a look at the rollup configuration to make sure this doesn't happen again, then I'll get a bug release out shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase library is wrongly bundled in react-firebase-hooks/auth
2 participants