Skip to content

Export IDOption type #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

Snailed
Copy link
Contributor

@Snailed Snailed commented Mar 22, 2021

Solution to issue #134
This change will make the IDOption type included in the built types, which will allow tsc to understand the DataOptions and OnceDataOptions types.

This is my first Open Source contribution, so I hope I did it right 😅

@chrisbianca chrisbianca merged commit 30bfd36 into CSFrequency:master Apr 16, 2021
@chrisbianca
Copy link
Contributor

@Snailed Congrats on your first Open Source contribution! Thank you for the submission, and sorry that it's taken so long to get this merged. It's interesting that IDOption needs to be exported at all, as it's only referenced within the file that it's defined in. It must be to do with how tsc is exporting the other types in the file.

I'll get this released shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants