Skip to content

[cmake] Set IS_DEBUG with asserts enabled #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[cmake] Set IS_DEBUG with asserts enabled #117

wants to merge 1 commit into from

Conversation

kerbowa
Copy link
Member

@kerbowa kerbowa commented Aug 22, 2020

No description provided.

@Quincunx271
Copy link
Member

I'm a little confused here. I don't what LLVM_DEBUG has to do with IS_DEBUG. However, I'm realizing that I never really understood why we would want -DLLVM_DEBUG=DEBUG.

@kerbowa
Copy link
Member Author

kerbowa commented Aug 22, 2020

I'm a little confused here. I don't what LLVM_DEBUG has to do with IS_DEBUG. However, I'm realizing that I never really understood why we would want -DLLVM_DEBUG=DEBUG.

Sorry, made a mistake when porting patch from develop->master.

The macro LLVM_DEBUG was renamed from DEBUG in LLVM 7. The aliasing here makes it so you can build OptSched with LLVM 6 or 7. Later versions of LLVM will only build with the "develop" branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerbowa @Quincunx271