WIP Prototype adjustments to jupyter/jupyter_client #308 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankatins
changed the title
|
I will try and find some time to look over this and the associated changes in jupyter client. I think it might be worth releasing a new version of the package for compatibility with the new versions of jupyter, which only has this implementation. Given most of our users are using conda / virtualenv to install jupyter encouraging people to upgrade seems reasonable to me. |
|
Jupyter client anyway needs to finalize the interface... |
jankatins
referenced
this pull request
in takluyver/jupyter_ssh_kernels
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Prototype implementation of environment kernels after jupyter/jupyter_client#308
This needs a big refactoring before the merge. Not sure if both ways should be kept or if only the new way should be in this package or if this should simply be forked into a new package...