Atlas 0.2.1 #9
Merged
Atlas 0.2.1 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses one of the issues raised in GH-2.
This ensures the output jar is compatible with the JDK's JarInputStream.
This includes a few doc comment improvements, but also has some logic improvements as well. First, this will handle cases where MANIFEST.MF isn't all-caps, as it technically doesn't have to be. JarFile will find any file in META-INF/ named MANIFEST.MF, ignoring case. By using JarFile directly to get the manifest rather than looking for the entry ourselves we remove the possibility of that issue causing a failure. We also now retrieve the manifest first, so if that fails somehowe we don't create the empty META-INF/ entry. By returning `true` only when the entries have been set we prevent a silent failure in the copyManifest() method from causing an error downstream (that is, the META-INF/ entry getting skipped later even though it wasn't copied).
To do this, they should return null rather than an entry. This fixes GH-8.
This was
linked to
issues
Jan 30, 2021
Closed
kashike
reviewed
Jan 30, 2021
| private final ExecutorService executorService; | ||
| private final boolean manageExecutor; | ||
|
|
||
| public Atlas(final ExecutorService executorService, final boolean manageExecutor) { |
There was a problem hiding this comment.
I mentioned suggestions about this stuff to you - commenting to remind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atlas 0.2.1 provides some quality-of-life features designed to make Atlas more configurable and accountable.