[eng-8492] Update to detach the metrics call to preprint metric failures from preventing the preprint detail page from loading #2604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eventing the preprint detail page from loading
adlius
approved these changes
Aug 1, 2025
adlius
merged commit baa5676
into
CenterForOpenScience:feature/pbs-25-12
9 checks passed
adlius
added a commit
that referenced
this pull request
Aug 1, 2025
* Added fix to break a race-condition error * Refactor to use the abstracted method * [eng-8159] Allow collections without metadata to be submitted * Added a new banner for all OSF preprints * Updates for the PR * Added an enabled true/false to prevent a race condition * Removed the unnecessary @enabled pass through variable * Forgot to save the template * Updates to fix the viewOnlyToken in cases there is a / or %2fF at the end (#2603) [ENG-8174] Extra Characters (%2F) in View-Only Files Tab URL Prevent Page from Loading * [eng-8492] Update to detach the metrics call to preprint metric failures from preventing the preprint detail page from loading (#2604) * Update to detach the metrics call to preprint metric failures from preventing the preprint detail page from loading * This is much better * Removed unneeded file * apiMetrics -> apiMeta (#2605) * fix again (#2606) --------- Co-authored-by: Brian Pilati <[email protected]> Co-authored-by: Lord Business <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update to detach the metrics call to preprint metric failures from preventing the preprint detail page from loading
Summary of Changes
Make to query calls: One to get the preprint and the other one to get the preprint with metrics.
Screenshot(s)
N/A
Side Effects
I can only test the "error" locally. By deduction it should work
QA Notes
You need to find a way to have the metrics server be down