Skip to content

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Aug 13, 2025

Purpose

when there are 10000+ search results, display that instead of "[object Object]" (as delightful as that is)

QA Notes

check osf search page /search

@aaxelb aaxelb force-pushed the fix/10k-objection branch from 1253b51 to 151b1ec Compare August 13, 2025 19:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16947003365

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.218%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/osf-components/addon/components/index-card-searcher/component.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 16687064986: 0.0%
Covered Lines: 8552
Relevant Lines: 12251

💛 - Coveralls

@aaxelb aaxelb marked this pull request as ready for review August 13, 2025 19:40
@aaxelb aaxelb requested a review from futa-ikeda August 13, 2025 19:41
Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear we had fixed this on the SHARE side? Looks good though

@aaxelb aaxelb merged commit c257752 into CenterForOpenScience:develop Aug 14, 2025
17 of 18 checks passed
@aaxelb aaxelb deleted the fix/10k-objection branch August 14, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants