Add linear interpolation option for voxel rendering #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #1719, so merge that first.
This adds support for linear interpolation in voxel rendering, similar to CesiumJS.
Note that the cylinder tileset is multiple tiles (as opposed to a single tile in the other datasets). Interpolation will be applied within each tile, but not across tiles. Cross-tile interpolation is meant to be applied by the padding property, which is not present in this dataset.
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).[ ] I have added or updated unit tests to ensure consistent code coverage as necessary.Testing plan
An option has been added to Cesium3DTileset under the Rendering category for this (feel free to suggest alternative design or organization):
You can see this most effectively using the
Voxelsample data in CesiumJS.