-
Notifications
You must be signed in to change notification settings - Fork 598
feat(screenshot): adds ability to output screenshot to a specific pat… #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(screenshot): adds ability to output screenshot to a specific pat… #172
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you please run npm run docs
and fix the failing test (npm ru n test
)?
Oh strange. Passed locally when isolated but failed when run as a group. Should be all good now |
7e27692
to
a4b5c8e
Compare
I’m wondering if there needs to be more robust checks for absolute or relative paths and non-writable directories. Thoughts? |
0d482f2
to
de1edd1
Compare
I think we can start with the current version but let's add that the path is either absolute or a path relative to the server's cwd |
Ok put a more detailed description and generated the docs |
21fdf8d
to
6bb0e65
Compare
🤖 I have created a release *beep* *boop* --- ## [0.6.0](chrome-devtools-mcp-v0.5.1...chrome-devtools-mcp-v0.6.0) (2025-10-01) ### Features * **screenshot:** add WebP format support with quality parameter ([#220](#220)) ([03e02a2](03e02a2)) * **screenshot:** adds ability to output screenshot to a specific pat… ([#172](#172)) ([f030726](f030726)) * support --accept-insecure-certs CLI ([#231](#231)) ([efb106d](efb106d)) * support --proxy-server CLI ([#230](#230)) ([dfacc75](dfacc75)) * support initial viewport in the CLI ([#229](#229)) ([ef61a08](ef61a08)) * support timeouts in wait_for and navigations ([#228](#228)) ([36e64d5](36e64d5)) ### Bug Fixes * **network:** show only selected request ([#236](#236)) ([73f0aec](73f0aec)) * PageCollector subscribing multiple times ([#241](#241)) ([0412878](0412878)) * snapshot does not capture Iframe content ([#217](#217)) ([ce356f2](ce356f2)), closes [#186](#186) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Closes #152. Closes #153