Skip to content

Conversation

james2doyle
Copy link
Contributor

@james2doyle james2doyle commented Sep 26, 2025

Closes #152. Closes #153

Copy link

google-cla bot commented Sep 26, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you please run npm run docs and fix the failing test (npm ru n test)?

@james2doyle
Copy link
Contributor Author

Oh strange. Passed locally when isolated but failed when run as a group. Should be all good now

@OrKoN OrKoN force-pushed the feature/screenshot-files branch from 7e27692 to a4b5c8e Compare September 29, 2025 16:36
@james2doyle
Copy link
Contributor Author

I’m wondering if there needs to be more robust checks for absolute or relative paths and non-writable directories. Thoughts?

@OrKoN OrKoN force-pushed the feature/screenshot-files branch from 0d482f2 to de1edd1 Compare September 30, 2025 06:04
@OrKoN
Copy link
Collaborator

OrKoN commented Sep 30, 2025

I’m wondering if there needs to be more robust checks for absolute or relative paths and non-writable directories. Thoughts?

I think we can start with the current version but let's add that the path is either absolute or a path relative to the server's cwd

@james2doyle
Copy link
Contributor Author

Ok put a more detailed description and generated the docs

@OrKoN OrKoN force-pushed the feature/screenshot-files branch from 21fdf8d to 6bb0e65 Compare September 30, 2025 17:50
@OrKoN OrKoN enabled auto-merge (squash) September 30, 2025 17:55
@OrKoN OrKoN disabled auto-merge September 30, 2025 17:56
@OrKoN OrKoN enabled auto-merge (squash) September 30, 2025 17:56
@OrKoN OrKoN disabled auto-merge September 30, 2025 17:56
@OrKoN OrKoN merged commit f030726 into ChromeDevTools:main Sep 30, 2025
16 checks passed
OrKoN pushed a commit that referenced this pull request Oct 1, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](chrome-devtools-mcp-v0.5.1...chrome-devtools-mcp-v0.6.0)
(2025-10-01)


### Features

* **screenshot:** add WebP format support with quality parameter
([#220](#220))
([03e02a2](03e02a2))
* **screenshot:** adds ability to output screenshot to a specific pat…
([#172](#172))
([f030726](f030726))
* support --accept-insecure-certs CLI
([#231](#231))
([efb106d](efb106d))
* support --proxy-server CLI
([#230](#230))
([dfacc75](dfacc75))
* support initial viewport in the CLI
([#229](#229))
([ef61a08](ef61a08))
* support timeouts in wait_for and navigations
([#228](#228))
([36e64d5](36e64d5))


### Bug Fixes

* **network:** show only selected request
([#236](#236))
([73f0aec](73f0aec))
* PageCollector subscribing multiple times
([#241](#241))
([0412878](0412878))
* snapshot does not capture Iframe content
([#217](#217))
([ce356f2](ce356f2)),
closes
[#186](#186)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add Save to File for take_snapshot and evaluate_script tools Allow setting the location of the temporary screenshot file

2 participants