fix: add an option value to the snapshot #237
Conversation
There was a problem hiding this comment.
Thanks! Let us use conventional commits for the PR title.
I think we should do the approach we discussed previously in which we resolve option label to a value when we will out an option. WDYT? I think doing evals during snapshot generation would be too expensive and bug-prone
Do you mean check if it is an option within |
src/tools/input.ts
Outdated
| await handle.asLocator().fill(request.params.value); | ||
| // The AXNode for an option doesn't contain its `value`. We set text content of the option as value. | ||
| // To fill the form, get the correct option by its text value. | ||
| const isSelectElement = await handle.evaluate( |
There was a problem hiding this comment.
Could we lookup the a11y node by uid in the snapshot instead and check if it is an option?
There was a problem hiding this comment.
the uid here is not for the option, but for a selector element.
We can look up that selector element by uid and check which of its childen value matches the one we are looking for. We still need to get its Element since we need to get the value that does not exist in the AXNode.
I changed it to do that
AlinaVarkki
changed the title
Fixes #185
The standard selector value is not included in the AXNode, so add it separately.