refactor: use context agnostic write to file #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlinaVarkki
approved these changes
Oct 2, 2025
Lightning00Blade
force-pushed
the
fix-up-writing-to-file
branch
from
09ac89e to
db8b96a
Compare
4 tasks
Coquinate
pushed a commit
to Coquinate/chrome-devtools-mcp
that referenced
this pull request
Oct 2, 2025
Updates take_snapshot and evaluate_script to use context.saveFile() instead of direct writeFile() calls, following the pattern established in PR ChromeDevTools#250. Changes: - Removed direct fs/promises imports - Convert string data to Uint8Array using TextEncoder - Use context.saveFile() for consistent file writing - Update response messages to use returned filename 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the write to temporary file we should hide the implementation behind the Context