Skip to content

Add timeout parameter #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add timeout parameter #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9ba9e0
Add timeout parameter
GerriorL Jul 18, 2022
0523882
Merge branch 'master' into GerriorL-update_timeout
GerriorL Sep 6, 2022
a0187a6
Update __init__.py
GerriorL Oct 5, 2022
2a7e030
Merge branch 'master' into GerriorL-update_timeout
Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .../changelog/undistributed/changelog_GerriorL_add_timeout_to_netconf_20220718.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
--------------------------------------------------------------------------------
Fix
--------------------------------------------------------------------------------
* yang.connector
* Modified netconf.py:
* Add custom timeout parameter to Netconf.connect
8 changes: 8 additions & 0 deletions connector/src/yang/connector/netconf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ def connect(self):
port: 830
username: admin
password: admin
timeout: 120

Code Example::

Expand Down Expand Up @@ -335,6 +336,7 @@ def connect(self):
'hostkey_verify': False,
'look_for_keys': False,
'ssh_config': None,
'timeout': 60
}
defaults.update(self.connection_info)

Expand Down Expand Up @@ -364,6 +366,12 @@ def connect(self):
except Exception:
pass

# check timeout
try:
defaults['timeout'] = int(self.connection_info['timeout'])
Copy link
Contributor

@tahigash tahigash Apr 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/CiscoTestAutomation/yang/blob/master/connector/src/yang/connector/netconf.py#L266

self.timeout already exist via __init__. you might want to use this instead to be simple.

and please be aware of that the timeout is already used here. https://github.com/CiscoTestAutomation/yang/blob/master/connector/src/yang/connector/netconf.py#L284

so the timeout value will be shared between this and your code.

except (KeyError, ValueError):
pass

# support sshtunnel
if 'sshtunnel' in defaults:
from unicon.sshutils import sshtunnel
Expand Down