Skip to content

Conversation

prime-time
Copy link
Contributor

Overview:
These console warnings have been driving me crazy for a while.

Screenshots/GIFs:
Before 😨 📣

After 😌 🔇

Testing:

  • Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE11

Roll Out:

  • Before merging:
    • Updated docs
    • Bumped version in package.json
      • Breaking change?
        • If it is a beta component run npm version minor
        • If the component is not in beta run npm version major
      • New component or backward-compatible component feature change? Run npm version minor
      • Only changing documentation? All good. Skip this step.
    • After creating a new component, make sure to add it to the Components List in ComponentsView.jsx. To do so:
      • Add an entry in ComponentsView.componentsToDisplay using this template:
        {
          componentLink: "<COMPONENT LINK>",
          componentImg: "<COMPONENT LINK>.png",
          componentName: "<COMPONENT NAME>",
          componentImgAlt: "A <COMPONENT NAME> component",
        },
        
      • Add a screenshot of the component in docs/assets/img with the format <COMPONENT LINK>.png
  • After merging:
    • Deployed updated docs (make deploy-docs)
    • Posted in #eng if I made a breaking change to a beta component

@prime-time prime-time force-pushed the silence-console-warnings branch from 5c6e0e2 to d323f2b Compare January 28, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants