Skip to content

SDK-1032: Prepare Android for v1.3.0 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 7, 2021
Merged

Conversation

william-ct
Copy link
Contributor

@william-ct william-ct commented Aug 27, 2021

Add Increment/ Decrement methods.
Add InApp control methods.
Deprecate profileGetCleverTapID() and profileGetCleverTapAttributionIdentifier().
Add a new public method getCleverTapID() as an alternative to above-deprecated methods.
Update version to 1.3.0

@Aditi3 Aditi3 changed the base branch from master to develop August 30, 2021 06:06
@darshanclevertap
Copy link
Contributor

@william-ct You need to update the CHANGELOG and README as well

Copy link
Contributor

@Aditi3 Aditi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move to version 1.3.0 instead of 1.2.4. Since the release includes feature(s)

@Aditi3 Aditi3 changed the title Task/prepare v1.2.4 Prepare Android for v1.3.0 Sep 6, 2021
@Aditi3 Aditi3 self-requested a review September 7, 2021 03:26
Copy link
Contributor

@Aditi3 Aditi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@Aditi3
Copy link
Contributor

Aditi3 commented Sep 7, 2021

Good to merge from my side @william-ct

Copy link
Contributor

@darshanclevertap darshanclevertap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@william-ct Just one change in the CHANGELOG, the rest looks good to me 👍🏾

Copy link
Contributor

@darshanclevertap darshanclevertap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@william-ct william-ct merged commit 940a524 into develop Sep 7, 2021
@william-ct william-ct changed the title Prepare Android for v1.3.0 SDK-1032: Prepare Android for v1.3.0 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants