Skip to content

templates and styling for upcoming events and event details #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2017

Conversation

davidchambers
Copy link
Contributor

Closes #13

This is not quite ready to merge, as there are few things I'd like to improve. Feel free to check out this branch and view the changes locally. :)

@Malwine
Copy link
Member

Malwine commented Apr 10, 2017

Looks super fancy!
giphy4

@Malwine
Copy link
Member

Malwine commented Apr 10, 2017

Could we also maybe have fallbacks if people provide wrong input e.g. for the map? That we show a gray area or something?

@Malwine
Copy link
Member

Malwine commented Apr 23, 2017

Would be great if you could include this: #21

@davidchambers davidchambers changed the base branch from gh-pages to master April 23, 2017 18:14
@davidchambers
Copy link
Contributor Author

ℹ️ I updated the target branch to master. I also deleted gh-pages to avoid confusion.

@@ -20,24 +20,21 @@
Upcoming Events
</h2>

{% assign upcoming_events = site.posts | where_exp: 'post', 'post.date >= site.time' %}
{% if upcoming_events.size == 0 %}
<p>There are no upcoming workshops.</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you could include this: #21

Here it is, @Malwine. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great. Can we merge this PR then?

@Malwine
Copy link
Member

Malwine commented Apr 23, 2017

When I start the local server I get this on the homepage:
screen shot 2017-04-23 at 20 23 20

@Malwine
Copy link
Member

Malwine commented Apr 23, 2017

@davidchambers Also Stockholm looks great but in Berlin I get this map:
screen shot 2017-04-23 at 20 24 14
Would be great to have a Fallback if address is wrong.

@davidchambers
Copy link
Contributor Author

When I start the local server I get [grey boxes] on the homepage[.]

I added support for organizer Gravatars, and defined city_image_url for the Stockholm post. :)

Would be great to have a Fallback if address is wrong.

What do you have in mind, exactly? If an organizer forgets to include latitude and longitude in the post metadata I'm not sure what we can display other than an empty map. It would be really nice to validate the post metadata and have Travis reject the pull request if validation fails, but that's out of scope. ;)

@Malwine
Copy link
Member

Malwine commented Apr 24, 2017

@davidchambers

  1. Gravatars 💯 🎉 👍

  2. If they forget latitude and longitude or don't know how to do it: Could we display a grey area/div? Because otherwise we get this "map error" thing which is not so nice 😰 :
    screen shot 2017-04-24 at 19 46 37

  3. Should the whole event div on the front page be clickable like on the current website? And should we add the hover text?
    newimage_1000_563_90

@davidchambers davidchambers force-pushed the davidchambers/events branch 2 times, most recently from 39acf0d to 4259fb7 Compare June 1, 2017 21:56
@davidchambers davidchambers force-pushed the davidchambers/events branch from 4259fb7 to 3160072 Compare June 1, 2017 21:58
latitude: 59.3371711
longitude: 18.0623905
date: 2018-05-05 18:00:00 +0200
workshop_dates: 5–6 May 2018
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the year from 2017 to 2018 so this workshop appears as an upcoming event. When I add the other completed workshops I will revert this to 2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants