Skip to content

Changing last_confirmed_view behavior #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
majecty opened this issue Oct 17, 2019 · 1 comment
Closed

Changing last_confirmed_view behavior #1816

majecty opened this issue Oct 17, 2019 · 1 comment

Comments

@majecty
Copy link
Contributor

majecty commented Oct 17, 2019

At which view a block is finalized is important information(Verifying signatures needs the view value). Since the information couldn't be written in the block data, we should keep it in other spaces. We can query the data in two places. One is the next block's seal. Tendermint seal data contains the previous block's finalized view data. The other one is the Tendermint module's last_confirmed_view

The problem is, the Tendermint module overwrites last_confirmed_view when it enters the Commit step to the current height's finalized view. If the Tendermint module doesn't receive any proposal block at the Commit state, we can't query the previous block's finalized view anywhere.

To solve the problem, I suggest saving both previous_block_finalized_view and current_block_finalized_view in the Tendermint module.

@majecty
Copy link
Contributor Author

majecty commented Oct 22, 2019

Fixed by #1820

@majecty majecty closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants