Skip to content

The view value is misused #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
majecty opened this issue Oct 17, 2019 · 1 comment
Closed

The view value is misused #1817

majecty opened this issue Oct 17, 2019 · 1 comment
Labels
bug Something isn't working consensus

Comments

@majecty
Copy link
Contributor

majecty commented Oct 17, 2019

A block author writes view data in the block's seal. The view value specifies when the author created the block. Other nodes use the view field to verify whether the block author is valid or not.

When a block is finalized, the next height's proposer writes the finalized view in the next block. There are signatures in a block. A signature is a precommit message for the previous block, and the message of the signature contains the finalized view. Thus, validators use the finalized view value to check the signature.

Hence, there are two values for a block. One is the "created" view that it is saved in the block, and the other one is the "finalized" that is saved in the next block.

Most of the time, the two view value will be identical. However, if there are network issues, the two values can differ. The current code assumes that the two values are the same. We should fix the code.

@majecty majecty added bug Something isn't working consensus labels Oct 17, 2019
@majecty majecty changed the title The view value is missused The view value is misused Oct 17, 2019
@majecty
Copy link
Contributor Author

majecty commented Oct 22, 2019

Fixed by #1820

@majecty majecty closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working consensus
Projects
None yet
Development

No branches or pull requests

1 participant