Change the definition of the asset type #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunsikjeong
added
state
rpc
transaction
breaking-change
do-not-merge
sgkim126
reviewed
Jan 23, 2019
hyunsikjeong
force-pushed
the
asset-type-split
branch
4 times, most recently
from
992bef2 to
3aede75
Compare
hyunsikjeong
force-pushed
the
asset-type-split
branch
from
f2877bb to
97d520c
Compare
hyunsikjeong
changed the title
|
Now passed all tests in my local environment. |
sgkim126
requested changes
Jan 23, 2019
from_transaction_hash_with_shard_id is removed because from_hash~ includes it.
hyunsikjeong
force-pushed
the
asset-type-split
branch
from
97d520c to
70bb896
Compare
added 6 commits
January 24, 2019 09:49
Old: (H256 of tracker of mint tx) + (shard id) New: H160 of tracker of mint tx only. shard_id field is added to each struct which has asset_type field.
The type of the asset type is changed to H160, and the shard ID is split from the asset type.
From AssetOutPoint/AssetTransferInput/AssetTransferOutput. shard_id field is already public, so there's no reason to retain those methods.
The type of the asset type is changed to H160, and the shard ID is split from the asset type.
The type of the asset type is changed to H160, and the shard ID is split from the asset type.
hyunsikjeong
force-pushed
the
asset-type-split
branch
from
70bb896 to
b302148
Compare
sgkim126
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1148 / Resolves: #1166
Old: (H256 of tracker of mint tx) + (shard id)
New: H160 of tracker of mint tx only.
AssetSchemeAddresswas exactly same as the asset type in the old definition.From the new definition,
AssetSchemeAddressis calculated from the shard id and the blake256 hash of the asset type.shard_idfield is added to each struct which hasasset_typefield.