Fix .dockerignore file to get commit hash successfully from docker image clients. #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get commithash successfully from the rpc "commithash" when using the released client as a docker image, removed .git from .dockerignore option. I checked there's no .git file in the final released image so it's safe to apply.
|
I think it's better to ignore the test directory also. |
The file keystore.db and the files under the test directory would not be used in building docker image. Therefore those files are excluded from building.
HoOngEe
force-pushed
the
fix/docker-commithash
branch
from
a797c2a to
5dbe1ca
Compare
|
Ok, the test directory is also ignored. |
|
LGTM |
foriequal0
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #1443