Skip to content

Do not wait before shutdown #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2019
Merged

Do not wait before shutdown #1498

merged 3 commits into from
May 9, 2019

Conversation

sgkim126
Copy link
Contributor

Currently, there is a hotfix to bypass the crash caused by the db that is open in the other threads.
But now you do not have to wait because it fixes the main thread to wait for joining the child threads.

It fixes #348.

@sgkim126
Copy link
Contributor Author

sgkim126 commented Apr 26, 2019

It depends on #1079 and #1496 They were merged

@sgkim126 sgkim126 added bug Something isn't working do-not-merge Do not merge (for mergify.io) labels Apr 26, 2019
Seulgi Kim added 2 commits May 9, 2019 09:59
The current code is a hotfix to bypass the crash caused by the db that
is open in the other threads.
But now you do not have to wait because the previous commits fixed the
main thread to wait for joining the child threads.
@sgkim126 sgkim126 removed the do-not-merge Do not merge (for mergify.io) label May 9, 2019
@sgkim126 sgkim126 requested review from foriequal0 and majecty May 9, 2019 01:04
Copy link
Contributor

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit ccc2372 into CodeChain-io:master May 9, 2019
@sgkim126 sgkim126 deleted the join branch May 9, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeChain crashes on SIGINT
3 participants