Reduce booting time by using is_empty method #1526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of codechain booting time is so slow when the db is heavy. The reason is that when codechain checks if db is empty, it used
db.keys().is_empty()
. The routine had collected all the keys in the db to a hashmap, so the majority of the booting time was occupied by the routine for iterating and collecting keys.I sent the method
is_empty
inJournalDB
up toHashDB
and used the method in db empty checking.It closes #1513