Skip to content

Change spec to use criminal's incomes as additional rewards #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2019
Merged

Change spec to use criminal's incomes as additional rewards #1562

merged 2 commits into from
May 31, 2019

Conversation

sgkim126
Copy link
Contributor

Hi,
Currently, the informant receives deposit and rewards of the criminal as a prize.
However, it incentives for informants to wait for reporting to maximize their profits.

So I propose giving the deposit to the informant and using the incomes as additional rewards for diligent validators.

@sgkim126
Copy link
Contributor Author

sgkim126 commented May 28, 2019

FYI, intermediate_rewards is cleared at the beginning of the term, not the end of the term, because it needs the signature of the last block in the term needs to calculate the penalty.

majecty
majecty previously approved these changes May 28, 2019
Copy link
Contributor

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kseo
Copy link
Member

kseo commented May 28, 2019

LGTM. Let's wait for @ScarletBlue's review.

foriequal0
foriequal0 previously approved these changes May 28, 2019
kseo
kseo previously approved these changes May 28, 2019
@kseo kseo requested review from kseo, foriequal0 and majecty May 28, 2019 05:31
@sgkim126 sgkim126 dismissed stale reviews from kseo, foriequal0, and majecty via 0b640d2 May 30, 2019 06:15
@mergify mergify bot merged commit ab9fdcb into CodeChain-io:master May 31, 2019
@@ -206,7 +206,8 @@ The transaction that reports a double vote have occurred before **WITHDRAW_DELAY

The criminal loses all his deposit and rewards and is banned immediately; it is the only case where a validator set is changed during the term.

The informant receives all deposit and rewards(TBD) as prize money immediately.
The informant receives the deposit of the criminal as prize money immediately.
The express fee that the criminal would earn is used as additional rewards for diligent validators.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The express fee that the criminal would have earned is used as additional rewards for diligent validators.

@sgkim126 sgkim126 deleted the fee-spec branch June 5, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants