Skip to content

Implement dynamic validator set #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2019
Merged

Implement dynamic validator set #1574

merged 4 commits into from
Jun 12, 2019

Conversation

sgkim126
Copy link
Contributor

No description provided.

@sgkim126
Copy link
Contributor Author

sgkim126 commented May 29, 2019 •
edited
Loading

It depends on #1559 and #1445

@sgkim126 sgkim126 mentioned this pull request Jun 7, 2019
Merged
@sgkim126 sgkim126 changed the title [WIP] Implement dynamic validator set Implement dynamic validator set Jun 7, 2019
@sgkim126
Copy link
Contributor Author

sgkim126 commented Jun 7, 2019 •
edited
Loading

@majecty and @foriequal0,
It depends on #1612 and #1598. I'll remove do-not-merge after they merged.
Please review it except Handle nomination expiration properly and Implement Encodable/Decodable for Tuple with three items

@sgkim126 sgkim126 added the do-not-merge Do not merge (for mergify.io) label Jun 7, 2019
@sgkim126 sgkim126 requested review from foriequal0 and majecty and removed request for foriequal0 June 7, 2019 05:09
majecty
majecty previously approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

foriequal0
foriequal0 previously approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@foriequal0 foriequal0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgkim126 sgkim126 removed the do-not-merge Do not merge (for mergify.io) label Jun 11, 2019
@sgkim126 sgkim126 requested review from foriequal0 and majecty and removed request for foriequal0 June 11, 2019 13:41
@mergify mergify bot merged commit a36a1ea into CodeChain-io:master Jun 12, 2019
@sgkim126 sgkim126 deleted the dyn branch June 12, 2019 02:25
@sgkim126 sgkim126 mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majecty majecty majecty approved these changes

@foriequal0 foriequal0 foriequal0 approved these changes

Assignees
No one assigned
Labels
consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgkim126 @majecty @foriequal0