Skip to content

Add stake parameters to CommonParams #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2019
Merged

Add stake parameters to CommonParams #1595

merged 2 commits into from
Jun 4, 2019

Conversation

sgkim126
Copy link
Contributor

@sgkim126 sgkim126 commented Jun 3, 2019

No description provided.

@sgkim126 sgkim126 added the scheme label Jun 3, 2019
@sgkim126 sgkim126 requested review from majecty and foriequal0 June 3, 2019 09:25
@sgkim126 sgkim126 added the do-not-merge Do not merge (for mergify.io) label Jun 3, 2019
@sgkim126
Copy link
Contributor Author

sgkim126 commented Jun 3, 2019

It also contains the change of #1597 I'll remove do-not-merge after merging #1597.

@sgkim126 sgkim126 changed the title Add stake information to params Add stake parameters to CommonParams Jun 3, 2019
@sgkim126 sgkim126 mentioned this pull request Jun 3, 2019
Merged
foriequal0
foriequal0 requested changes Jun 4, 2019
View reviewed changes
@sgkim126 sgkim126 requested a review from foriequal0 June 4, 2019 02:20
majecty
majecty approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@majecty majecty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgkim126 sgkim126 removed the do-not-merge Do not merge (for mergify.io) label Jun 4, 2019
@sgkim126
Copy link
Contributor Author

sgkim126 commented Jun 4, 2019

#1597 is merged

@mergify mergify bot merged commit 9e08b38 into CodeChain-io:master Jun 4, 2019
@sgkim126 sgkim126 deleted the params branch June 4, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majecty majecty majecty approved these changes

@foriequal0 foriequal0 foriequal0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgkim126 @majecty @foriequal0