Move to Commit state if enough precommits are collected #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since TendermintState has more information than Step, using TendermintState is better. Also, if TendermintState::Commit has block_hash as a field, Step -> TendermintState conversion will be broken.
majecty
commented
Sep 10, 2019
| return | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Before this PR, previous rounds' precommit is ignored.
After this PR, previous rounds' precommits are enough received, the node moves to Commit state.
majecty
commented
Sep 10, 2019
| cwarn!(ENGINE, "Cannot find a proposal which committed"); | ||
| self.increment_view(1); | ||
| Some(Step::Propose) | ||
| } |
There was a problem hiding this comment.
Before this PR, if the committed block is not imported when moving to the Commit state, the node moves to the next round.
After this PR, the node moves to Commit state and waits for the block.
foriequal0
requested changes
Sep 11, 2019
majecty
force-pushed
the
f/commit-block-import
branch
from
011ca48 to
f63dbcc
Compare
foriequal0
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.