Stop generating blocks if the consensus cannot make a seal #1792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScarletBlue
changed the title
foriequal0
requested changes
Sep 24, 2019
If Tendermint consensus received an outdated block request, it returns empty seal. Miner should stop the block generation if the seal is empty.
majecty
force-pushed
the
f/seal-empty
branch
from
5077c9c to
c22246c
Compare
foriequal0
reviewed
Sep 25, 2019
| @@ -837,13 +840,17 @@ impl MinerService for Miner { | |||
| let parent_block_number = chain.block_header(&parent_block).expect("Parent is always exist").number(); | |||
| if self.requires_reseal(parent_block_number) { | |||
| let (block, original_work_hash) = match self.prepare_block(parent_block, chain) { | |||
| Ok((block, original_work_hash)) => { | |||
| Ok(Some((block, original_work_hash))) => { | |||
There was a problem hiding this comment.
BTW, block and original_work_hash are duplicated 3 times. It can be reduced with
let (block, original_work_hash) = match ... {
Ok(Some(prepared @ (block, _))) => {
...
prepared
}
...
};
foriequal0
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Tendermint consensus receives an outdated block request, it returns
an empty seal. The miner should stop block generation if the seal is empty.